Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Oct 7, 2020

No description provided.

@Remi-Gau Remi-Gau changed the title getting ready for a version bump getting ready for a version bump: v1.0.1 Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #109 into master will increase coverage by 0.80%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   79.09%   79.90%   +0.80%     
==========================================
  Files          26       28       +2     
  Lines         550      602      +52     
==========================================
+ Hits          435      481      +46     
- Misses        115      121       +6     
Flag Coverage Δ
#unittests 79.90% <89.28%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/convertSourceToRaw.m 0.00% <ø> (ø)
src/createDatasetDescription.m 0.00% <ø> (ø)
src/createFilename.m 95.89% <ø> (ø)
src/createJson.m 51.21% <ø> (ø)
src/saveEventsFile.m 94.16% <ø> (ø)
src/subfun/askForGroupAndOrSession.m 100.00% <ø> (ø)
src/subfun/askUserCli.m 0.00% <ø> (ø)
src/subfun/askUserGui.m 0.00% <ø> (ø)
src/subfun/checkCppBidsDependencies.m 50.00% <ø> (ø)
src/subfun/createQuestionList.m 100.00% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3c9bf...caec75b. Read the comment docs.

@Remi-Gau
Copy link
Contributor Author

@marcobarilari I quickly checked and we had not changed anything on this repo for your experiment on our last trip to Liège so I am going to fix the last problem with Travis and merge this. 🚀

@Remi-Gau Remi-Gau changed the title getting ready for a version bump: v1.0.1 getting ready for a version bump: v1.1.0 Oct 13, 2020
@Remi-Gau Remi-Gau merged commit 1cab369 into cpp-lln-lab:master Oct 13, 2020
@marcobarilari
Copy link
Collaborator

I am not sure I understand what you mean but it's ok :)

@Remi-Gau
Copy link
Contributor Author

Sorry. I meant that I checked the code in the CPP_BIDS submodule from your bimodal experiment that we used : and there was no change in there, so that meant we could proceed with this.

For the CPP PTB we made a couple of changes on your side, so I want to include those before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants